fix: modify ExpressionFilter.canVectorizeMatcher and AggregatorUtil.canVectorize to use ExpressionPlanner.plan#19245
Open
clintropolis wants to merge 2 commits intoapache:masterfrom
Open
Conversation
…ze to use ExpressionPlanner.plan changes: * `ExpressionFilter.canVectorizeMatcher` and `AggregatorUtil.canVectorize` now use `ExpressionPlanner.plan` to check for `Trait.VECTORIZABLE` instead of calling `Expr.canVectorize` directly * updated javadoc for `Expr.canVectorize` to indicate that it alone isn't sufficient to decide if vector processing should be used * update `BaseFilterTest.assertFilterMatchesSkipVectorize` to now assert that the cursor factory is not vectorizable (or not a `ColumnarFrameCursorFactory`) so that we do not accidentally skip vectorization for things that are vectorizable, which would have caught the bug for `ExpressionFilter`, fixed up tests that were incorrectly skipping vector coverage * update `AggregatorUtilTest` to cover `canVectorize`
clintropolis
changed the title
gianm
approved these changes
Apr 1, 2026
clintropolis
changed the title
clintropolis
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
changes:
ExpressionFilter.canVectorizeMatcherandAggregatorUtil.canVectorizenow useExpressionPlanner.planto check forTrait.VECTORIZABLEinstead of callingExpr.canVectorizedirectlyExpr.canVectorizeto indicate that it alone isn't sufficient to decide if vector processing should be usedBaseFilterTest.assertFilterMatchesSkipVectorizeto now assert that the cursor factory is not vectorizable (or not aColumnarFrameCursorFactory) so that we do not accidentally skip vectorization for things that are vectorizable, which would have caught the bug forExpressionFilter, fixed up tests that were incorrectly skipping vector coverageAggregatorUtilTestto covercanVectorize