fix: Handle poll idle ratio not being available.#19246
Merged
cryptoe merged 1 commit intoapache:masterfrom Apr 1, 2026
Merged
Conversation
The change to RecordSupplier allows Kinesis task live reports to work again. They had been throwing UnsupportedOperationException. The change to CostBasedAutoScaler differentiates poll idle ratio of -1 (no data) from 0 (never idle). There was already some logic in the class for dealing with the negative case: it would treat it like 0.5. But this logic had not been reachable due to extractPollIdleRatio returning 0 rather than -1 for the no-data case.
Fly-Style
approved these changes
Apr 1, 2026
Contributor
Fly-Style
left a comment
Fly-Style
left a comment
There was a problem hiding this comment.
Thanks for catching a good path to unblock it, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change to RecordSupplier allows Kinesis task live reports to work again. They had been throwing UnsupportedOperationException.
The change to CostBasedAutoScaler differentiates poll idle ratio of -1 (no data) from 0 (never idle). There was already some logic in the class for dealing with the negative case: it would treat it like 0.5. But this logic had not been reachable due to extractPollIdleRatio returning 0 rather than -1 for the no-data case.