-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat: fix console bugs and makes console functions effective #1378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c16e7db to
ec1454e
Compare
ec1454e to
7e3d067
Compare
a78f9d2 to
e9f6b0a
Compare
|
|
Merged first for better joint debugging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements a rule governor system to make console operations effective by properly propagating configuration changes to the underlying registry (Nacos/Zookeeper). The changes include renaming a core interface method for clarity, adding a governor layer to handle rule CRUD operations, updating console services to use the new architecture, and adding necessary indexes for improved querying.
Changes:
- Renamed
MeshName()toResourceMesh()across all resource types for consistency - Added new
RuleGovernorcomponent with Nacos2 and Zookeeper implementations to make rule operations effective - Updated
ResourceManagerto integrate with governor for rule resources (DynamicConfig, ConditionRoute, TagRoute) - Enhanced console services with complete implementations for search, configuration management, and instance operations
- Added new store indexes and helper functions for improved resource querying
Reviewed changes
Copilot reviewed 90 out of 92 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ui-vue3/yarn.lock | Added frontend dependencies (defu, js-cookie, pinia-plugin-persistedstate) |
| scripts/resourcegen/gen.go | Updated code generator template to use ResourceMesh() |
| pkg/store//store.go | Updated all store implementations to use ResourceMesh() |
| pkg/governor/* | New governor package with Nacos2 and ZK implementations |
| pkg/core/manager/manager.go | Integrated governor for rule CRUD operations |
| pkg/core/resource/model/resource.go | Renamed MeshName() to ResourceMesh() |
| pkg/core/resource/apis/mesh/v1alpha1/* | Updated all resource types to implement ResourceMesh() |
| pkg/console/service/* | Implemented complete service layer functions |
| pkg/console/handler/* | Updated handlers to use new service implementations |
| pkg/config/* | Added engine ID validation and helper methods |
| api/mesh/v1alpha1/* | Added sourceEngine field to Instance proto, simplified ConditionRoute |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.



Please provide a description of this PR:
fix console bugs and makes console functions effective
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.
Please check any characteristics that apply to this pull request.