fix: Fix problematic error returns#2791
Merged
No-SilverBullet merged 1 commit intoapache:mainfrom Mar 9, 2025
Merged
Conversation
Signed-off-by: cuishuang <imcusg@gmail.com>
|
No-SilverBullet
approved these changes
Mar 9, 2025
Member
No-SilverBullet
left a comment
No-SilverBullet
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contribution :)
AlexStocks
pushed a commit
that referenced
this pull request
Mar 16, 2025
* fix: Fix problematic error returns (#2791) Signed-off-by: cuishuang <imcusg@gmail.com> * chore: fix some comments (#2793) Signed-off-by: cuishuang <imcusg@gmail.com> * fix:invalid timeout * delete comment --------- Signed-off-by: cuishuang <imcusg@gmail.com> Co-authored-by: cui fliter <imcusg@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here
sendErrshould be returned instead oferr.