Skip to content

fix issue 2683: defeat memory leak#2792

Merged
No-SilverBullet merged 2 commits intoapache:developfrom
LQyt2012:develop
Mar 10, 2025
Merged

fix issue 2683: defeat memory leak#2792
No-SilverBullet merged 2 commits intoapache:developfrom
LQyt2012:develop

Conversation

@LQyt2012
Copy link
Contributor

@LQyt2012 LQyt2012 commented Mar 9, 2025

There is a memory leak when using the dubbo-go-hessian2 protocol(#2683). Since the dubbo-go-hessian2 already fixed in (apache/dubbo-go-hessian2#374) and released a new version with tag v1.12.5. So update the version in dubbo-go.

The rc.id is always nil because it is never assigned.
there is a memory leak in dubbo-go-hessian2, then need to update the version of dubbo-go-hessian2.
@No-SilverBullet
Copy link
Member

please check the CI error

@AlexStocks AlexStocks changed the title fix issue 2683 fix issue 2683: defeat memory leak Mar 9, 2025
@LQyt2012 LQyt2012 closed this Mar 9, 2025
@LQyt2012 LQyt2012 reopened this Mar 9, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 9, 2025

Copy link
Member

@No-SilverBullet No-SilverBullet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@No-SilverBullet No-SilverBullet merged commit db2cc25 into apache:develop Mar 10, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants