Fix: Triple protocol streaming does not correctly handle context ctx attachments errors#2810
Merged
AlexStocks merged 15 commits intoapache:developfrom Mar 23, 2025
1kasa:develop
Merged
Fix: Triple protocol streaming does not correctly handle context ctx attachments errors#2810AlexStocks merged 15 commits intoapache:developfrom 1kasa:develop
AlexStocks merged 15 commits intoapache:developfrom
1kasa:develop
Conversation
…ia Peek to properly close the connection
…ia Peek to properly close the connection
…attachments errors
…attachments errors
…attachments errors
…attachments errors
…attachments errors
cjphaha
reviewed
Mar 22, 2025
…attachments errors
Member
|
LGTM, but is there any unit test to verify this PR? |
|
Contributor
Author
None, no unit tests, but can be verified via https://github.com/apache/dubbo-go-samples/tree/main/compatibility/context/triple |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix：#2808
Error cause description：
The context data transfer is not handled correctly in triple streaming, resulting in the conversion of the null value (nil) of the interface{} type to the []string type, but it fails.