Skip to content

fix: url equal with interface any value#3061

Closed
CAICAIIs wants to merge 1 commit intoapache:developfrom
CAICAIIs:interface
Closed

fix: url equal with interface any value#3061
CAICAIIs wants to merge 1 commit intoapache:developfrom
CAICAIIs:interface

Conversation

@CAICAIIs
Copy link
Copy Markdown
Contributor

  • Fix URL equality to support interface=* (AnyValue) matching, consistent with group=*.
  • Update URLEqual() to replace wildcard with the concrete interface when comparing keys.
  • Add unit tests for forward, reverse, and negative cases.

@sonarqubecloud
Copy link
Copy Markdown

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.36%. Comparing base (bd001fe) to head (e96d90f).
⚠️ Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3061      +/-   ##
===========================================
+ Coverage    39.61%   40.36%   +0.75%     
===========================================
  Files          457      457              
  Lines        39072    32421    -6651     
===========================================
- Hits         15479    13088    -2391     
+ Misses       22331    18071    -4260     
  Partials      1262     1262              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Alanxtl
Copy link
Copy Markdown
Contributor

Alanxtl commented Oct 25, 2025

  1. Does this PR links to any issues? If so, please paste the reference issue URL in the pr description.
  2. I'm not sure if there is really a condition that the invocation will denote an interface with a wildcard?

@CAICAIIs
Copy link
Copy Markdown
Contributor Author

  1. Does this PR links to any issues? If so, please paste the reference issue URL in the pr description.
  2. I'm not sure if there is really a condition that the invocation will denote an interface with a wildcard?

This PR is not linked to any issue. I came across a TODO while reading the code and thought I'd try to address it. If it's not appropriate, I'll close the PR.

@Alanxtl
Copy link
Copy Markdown
Contributor

Alanxtl commented Oct 26, 2025

@marsevilspirit

@marsevilspirit
Copy link
Copy Markdown
Member

At present, dubbo-go is not suitable for adding features. It will be discussed when it is stable.

@CAICAIIs CAICAIIs closed this Oct 31, 2025
@CAICAIIs CAICAIIs deleted the interface branch October 31, 2025 12:07
@CAICAIIs CAICAIIs restored the interface branch October 31, 2025 12:07
@CAICAIIs CAICAIIs deleted the interface branch November 23, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants