Skip to content

Conversation

@biggates
Copy link

@biggates biggates commented Jun 15, 2023

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

  • Adds sampling support in dataZoom

Fixed issues

Details

Before: What was the problem?

the sampling method in dataZoomSlider is not the same as in series. In rare cases (lots of fast changing points), it may result in incorrect shape.

图片

After: How does it behave after the fixing?

called the same processing function in dataZoomSlider as in dataSample(), and will fallback to the old implementation if sampling is not applicable.

图片

Document Info

One of the following should be checked.

This PR will add an additional optional configuration sampling in dataZoom so an update is required.

Misc

Related test cases or examples to use the new APIs

  • test case: dataZoom-sampling.html

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Jun 15, 2023

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

@biggates biggates changed the title Fix 18754: Adds sampling support to dataZoomSlider Fix #18754: [Feature] Adds sampling support to dataZoomSlider Jun 15, 2023
@biggates biggates changed the title Fix #18754: [Feature] Adds sampling support to dataZoomSlider Fix #18754 - [Feature] Adds sampling support to dataZoomSlider Jun 15, 2023
@echarts-bot echarts-bot bot added PR: doc ready and removed PR: awaiting doc Document changes is required for this PR. labels Jun 20, 2023
@biggates
Copy link
Author

I switched to a 4k display (window.devicePixelRatio = 1.5) recently and found the usage of dpr may cause miscalculation rate, and will cause the misalignment on the dataZoomSlider and the full data series.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant