Fix #5205: Handle invalid SubscriptionMode values safely#5218
Fix #5205: Handle invalid SubscriptionMode values safely#5218nagarjunahp88-byte wants to merge 3 commits intoapache:masterfrom
Conversation
There was a problem hiding this comment.
Welcome to the Apache EventMesh community!!
This is your first PR in our project. We're very excited to have you onboard contributing. Your contributions are greatly appreciated!
Please make sure that the changes are covered by tests.
We will be here shortly.
Let us know if you need any help!
Want to get closer to the community?
| WeChat Assistant | WeChat Public Account | Slack |
|---|---|---|
![]() |
![]() |
Join Slack Chat |
Mailing Lists:
| Name | Description | Subscribe | Unsubscribe | Archive |
|---|---|---|---|---|
| Users | User support and questions mailing list | Subscribe | Unsubscribe | Mail Archives |
| Development | Development related discussions | Subscribe | Unsubscribe | Mail Archives |
| Commits | All commits to repositories | Subscribe | Unsubscribe | Mail Archives |
| Issues | Issues or PRs comments and reviews | Subscribe | Unsubscribe | Mail Archives |
|
plz check code style |
|
Thanks for the review! |
|
Hi, I’m a new contributor. |
|
The CI failure seems to be related to Gradle build scan publishing Please let me know if this is expected or if any change is needed |
0a5402c to
b4e566f
Compare
|
It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback. If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh. |


This PR fixes issue #5205 by improving SubscriptionModeConverter.
Changes:
This ensures the application does not crash on invalid input.