feat(core): Add font style cloning method and optimize style merging …#326
Merged
psxjoy merged 2 commits intoapache:mainfrom Apr 22, 2025
Merged
Conversation
…logic Added clone() method in WriteFont class to implement deep copy of font styles. Optimized the style merging logic in WriteCellStyle class to ensure that the font of the source style is correctly copied to the target style. Introduced ColorDemoData and WriteWithColor classes for demonstrating and testing the application of color styles.
Contributor
Author
psxjoy
requested changes
Apr 14, 2025
fastexcel-test/src/test/java/cn/idev/excel/test/demo/write/ColorDemoData.java
Outdated
Show resolved
Hide resolved
fastexcel-test/src/test/java/cn/idev/excel/test/demo/write/ColorDemoData.java
Outdated
Show resolved
Hide resolved
fastexcel-test/src/test/java/cn/idev/excel/test/demo/write/WriteWithColor.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@psxjoy Okay, I've already revised and resubmitted it. |
psxjoy
approved these changes
Apr 14, 2025
Member
psxjoy
left a comment
There was a problem hiding this comment.
when version 1.2.0 released.I will start merge this PR:)
Contributor
Author
Is this issue present in EasyExcel too? Need me to create a pull request? |
Member
I think easyexcel also has this problem. |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




…logic
Added clone() method in WriteFont class to implement deep copy of font styles.
Optimized the style merging logic in WriteCellStyle class to ensure that the font of the source style is correctly copied to the target style.
Introduced ColorDemoData and WriteWithColor classes for demonstrating and testing the application of color styles.