Skip to content

Update poi-ooxml version#335

Closed
leshalv wants to merge 3 commits intoapache:mainfrom
leshalv:patch-1
Closed

Update poi-ooxml version#335
leshalv wants to merge 3 commits intoapache:mainfrom
leshalv:patch-1

Conversation

@leshalv
Copy link

@leshalv leshalv commented Apr 21, 2025

Copy link
Member

@alaahong alaahong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not update to 5.4.1 ?

@psxjoy
Copy link
Member

psxjoy commented Apr 22, 2025

I think @alaahong is right. Let's update to 5.4.1!

@psxjoy psxjoy self-requested a review April 22, 2025 12:03
Copy link
Member

@psxjoy psxjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5.4.1 is best

@psxjoy
Copy link
Member

psxjoy commented Apr 22, 2025

seems like unit-test error. I think we can not update to 5.4.1 directly?

@leshalv
Copy link
Author

leshalv commented Apr 28, 2025

我在本机进行了测试,可以呢

@leshalv leshalv requested review from alaahong and psxjoy April 28, 2025 01:02
@alaahong
Copy link
Member

alaahong commented Apr 28, 2025

Same error as Github actions on POI 5.3.0 and POI-OOXML 5.4.1
image

image

Another error on both 5.4.1 or 5.4.0 of POI and POI-OOXML
image
image

both 5.3.0 are fine
image

@psxjoy seems a breaking change by POI since 5.4.X ? It might not only impact on unit test, it should be more on existing code usage. It should be discussed on the project level?

@psxjoy psxjoy added the pending This problem needs to be confirmed label Apr 28, 2025
@psxjoy
Copy link
Member

psxjoy commented Apr 28, 2025

Same error as Github actions on POI 5.3.0 and POI-OOXML 5.4.1 image

image

Another error on both 5.4.1 or 5.4.0 of POI and POI-OOXML image image

both 5.3.0 are fine image

@psxjoy seems a breaking change by POI since 5.4.X ? It might not only impact on unit test, it should be more on existing code usage. It should be discussed on the project level?

Maybe we should discuss about the update of poi.

@delei
Copy link
Member

delei commented May 6, 2025

poipoi-ooxml是否同步都升级到5.4.1?

@psxjoy
Copy link
Member

psxjoy commented May 13, 2025

@delei , you're right .both update to 5.4.1,all unit-tests passed.
Can you submit a PR for this?

@delei
Copy link
Member

delei commented May 13, 2025

Seems a breaking change by POI since 5.4.X ? I can try it

@psxjoy
Copy link
Member

psxjoy commented May 13, 2025

Seems a breaking change by POI since 5.4.X ? I can try it

I think poi and poi-ooxml must update to 5.4.1 at the same time:)

@delei
Copy link
Member

delei commented May 13, 2025

我提交了一个新的 PR,本地和 Github Action 均已通过单元测试,可以平滑的升级到 5.4.1

I submit a new PR for it.It seems all unit-tests passed. smooth upgrade poi version to 5.4.1

@psxjoy psxjoy closed this May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pending This problem needs to be confirmed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

第三方的依赖Apache Commons Compress 版本建议升级一下

4 participants