Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,6 @@ public void finish() {
}

// close csv.
// https://github.com/fast-excel/fastexcel/issues/2309
try {
if ((readWorkbookHolder instanceof CsvReadWorkbookHolder)
&& ((CsvReadWorkbookHolder) readWorkbookHolder).getCsvParser() != null
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ public void processRecord(XlsReadContext xlsReadContext, Record record) {
xlsReadSheetHolder.setTempRowType(RowTypeEnum.EMPTY);
} else if (record instanceof MissingCellDummyRecord) {
MissingCellDummyRecord mcdr = (MissingCellDummyRecord) record;
// https://github.com/fast-excel/fastexcel/issues/2236
// Some abnormal XLS, in the case of data already exist, or there will be a "MissingCellDummyRecord"
// records, so if the existing data, empty data is ignored
xlsReadSheetHolder
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,7 @@ private Object buildNoModel(
}
}
}
// fix https://github.com/fast-excel/fastexcel/issues/2014
int headSize = calculateHeadSize(readSheetHolder);
// fix https://github.com/fast-excel/fastexcel/issues/220
while (index <= headSize) {
map.put(index, null);
index++;
Expand Down Expand Up @@ -178,7 +176,6 @@ private Object buildUserModel(
dataMap.put(fieldName, value);

// 规避由于实体类 setter 不规范导致无法赋值的问题
// fix https://github.com/alibaba/easyexcel/issues/3524
if (dataMap.get(fieldName) == null) {
Object bean = dataMap.getBean();
try {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ public class ReadSheetHolder extends AbstractReadHolder {
private ReadCellData<?> tempCellData;
/**
* Read the size of the largest head in sheet head data.
* see https://github.com/fast-excel/fastexcel/issues/2014
*/
private Integer maxNotEmptyDataHeadSize;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ public class BeanMapUtils {
* <code>BeanMap.Generator</code> instead of this static method.
*
* Custom naming policy to prevent null pointer exceptions.
* see: https://github.com/fast-excel/fastexcel/issues/2064
*
* @param bean the JavaBean underlying the map
* @return a new <code>BeanMap</code> instance
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ private void addBasicTypeToExcel(RowData oneRowData, Row row, int rowIndex, int
if (dataIndex >= oneRowData.size()) {
return;
}
// fix https://github.com/fast-excel/fastexcel/issues/1702
// If there is data, it is written to the next cell
maxCellIndex++;

Expand Down Expand Up @@ -220,7 +219,6 @@ private void addJavaObjectToExcel(Object oneRowData, Row row, int rowIndex, int
excelContentProperty);
WriteHandlerUtils.beforeCellCreate(cellWriteHandlerContext);

// fix https://github.com/fast-excel/fastexcel/issues/1870
// If there is data, it is written to the next cell
Cell cell = WorkBookUtil.createCell(row, maxCellIndex);
cellWriteHandlerContext.setCell(cell);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,6 @@ private void checkRowHeight(AnalysisCell analysisCell, FillConfig fillConfig, bo
if (!analysisCell.getFirstRow() || !WriteDirectionEnum.VERTICAL.equals(fillConfig.getDirection())) {
return;
}
// fix https://github.com/fast-excel/fastexcel/issues/1869
if (isOriginalCell && PoiUtils.customHeight(row)) {
collectionRowHeightCache.put(currentUniqueDataFlag, row.getHeight());
return;
Expand Down Expand Up @@ -562,7 +561,6 @@ private String prepareData(
analysisCell.getVariableList().add(variable);
if (lastPrepareDataIndex == prefixIndex) {
analysisCell.getPrepareDataList().add(StringUtils.EMPTY);
// fix https://github.com/fast-excel/fastexcel/issues/2035
if (lastPrepareDataIndex != 0) {
analysisCell.setOnlyOneVariable(Boolean.FALSE);
}
Expand All @@ -574,7 +572,6 @@ private String prepareData(
}
lastPrepareDataIndex = suffixIndex + 1;
}
// fix https://github.com/fast-excel/fastexcel/issues/1552
// When read template, XLSX data may be in `is` labels, and set the time set in `v` label, lead to can't set
// up successfully, so all data format to empty first.
if (analysisCell != null && CollectionUtils.isNotEmpty(analysisCell.getVariableList())) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@

/**
* Handle the problem of unable to write dimension.
*
* https://github.com/fast-excel/fastexcel/issues/1282
*
*
*/
@Slf4j
public class DimensionWorkbookWriteHandler implements WorkbookWriteHandler {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ public class CompatibilityTest {

@Test
public void t01() {
// https://github.com/fast-excel/fastexcel/issues/2236
List<Map<Integer, Object>> list = FastExcel.read(TestFileUtil.getPath() + "compatibility/t01.xls")
.sheet()
.doReadSync();
Expand Down Expand Up @@ -78,7 +77,6 @@ public void t04() {

@Test
public void t05() {
// https://github.com/fast-excel/fastexcel/issues/1956
// Excel read date needs to be rounded
List<Map<Integer, String>> list = FastExcel.read(TestFileUtil.getPath() + "compatibility/t05.xlsx")
.sheet()
Expand All @@ -104,7 +102,6 @@ public void t06() {

@Test
public void t07() {
// https://github.com/fast-excel/fastexcel/issues/2805
// Excel read date needs to be rounded
List<Map<Integer, Object>> list = FastExcel.read(TestFileUtil.getPath() + "compatibility/t07.xlsx")
.readDefaultReturn(ReadDefaultReturnEnum.ACTUAL_DATA)
Expand All @@ -123,7 +120,6 @@ public void t07() {

@Test
public void t08() {
// https://github.com/fast-excel/fastexcel/issues/2693
// Temporary files may be deleted if there is no operation for a long time, so they need to be recreated.
File file = TestFileUtil.createNewFile("compatibility/t08.xlsx");
FastExcel.write(file, SimpleData.class).sheet().doWrite(data());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import org.apache.poi.ss.usermodel.Hyperlink;

/**
* 自定义拦截器。对第一行第一列的头超链接到:https://github.com/fast-excel/fastexcel
* 自定义拦截器
*
*
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,6 @@ public void testHolder() {
excelWriter.write(csvDataList, writeSheet);
}

// https://github.com/alibaba/FastExcel/issues/3868
csvFile = TestFileUtil.readFile(CSV_BASE + "csv-delimiter.csv");
try (ExcelReader excelReader =
FastExcel.read(csvFile, CsvData.class, new CsvDataListener()).build()) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public void IssueTest1() {
.doRead();
}

// CS304 (manually written) Issue link: https://github.com/alibaba/FastExcel/issues/2319
@Test
public void IssueTest2() {
String fileName = TestFileUtil.getPath() + "temp/issue2319" + File.separator + "test2.xlsx";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@

@Slf4j
public class Issue2443Test {
// CS304 (manually written) Issue link: https://github.com/fast-excel/fastexcel/issues/2443
@Test
public void IssueTest1() {
String fileName = TestFileUtil.getPath() + "temp/issue2443" + File.separator + "date1.xlsx";
Expand All @@ -27,7 +26,6 @@ public void IssueTest1() {
.doRead();
}

// CS304 (manually written) Issue link: https://github.com/fast-excel/fastexcel/issues/2443
@Test
public void IssueTest2() {
String fileName = TestFileUtil.getPath() + "temp/issue2443" + File.separator + "date2.xlsx";
Expand Down