Skip to content

Conversation

@delei
Copy link
Member

@delei delei commented Oct 25, 2025

Purpose of the pull request

Related #657

What's changed?

Office requires that the name attribute be less than or equal to 31 characters in length and follow the character limitations for sheet-name.

  • Introduced Workbook constant for maximum sheet name length validation in ExcelWriterSheetBuilder

Checklist

  • I have read the Contributor Guide.
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Copy link
Member

@alaahong alaahong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@psxjoy psxjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delei delei merged commit 9b17091 into apache:main Oct 27, 2025
8 checks passed
@delei delei deleted the issue-657 branch November 2, 2025 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants