Skip to content

Conversation

@GOODBOY008
Copy link
Member

This pull request updates several GitHub Actions workflow files to restrict when certain jobs run, ensuring that scheduled or sensitive jobs only execute for the apache/fesod repository. This helps prevent unnecessary or unintended workflow runs on forks or other repositories.

Workflow job execution restrictions:

  • Added conditional execution to the codeql job in .github/workflows/codeql-scan.yml, so it only runs on schedule for the main repository or always for other event types.
  • Added conditional execution to the fuzz job in .github/workflows/fuzz-tests.yml, mirroring the logic used for the CodeQL job.
  • Added conditional execution to the nightly-test job in .github/workflows/nightly.yml, restricting scheduled runs to the main repository.

Repository-specific deployment and release:

  • Restricted the deploy job in .github/workflows/deploy-docs.yml to only run for the apache/fesod repository.
  • Restricted the publish job in .github/workflows/release.yml to only run for the apache/fesod repository.

@delei delei requested a review from alaahong October 30, 2025 09:26
@alaahong
Copy link
Member

It's good point to enhance the CI.
Just wonder if which flows will run besides FESOD repo and make confusing on fork repo?
And meanwhile, why not keep quality check in per commit or pr?

@GOODBOY008
Copy link
Member Author

Q1:The pr remove meanless schedule ci on fork repo, did not reduce this repo ci.

Q2: Ditto.

Copy link
Member

@alaahong alaahong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems all schedule checking are not required.
And meanwhile all changes in manual action are not required.
Please limited the repository condition only on schedule action.

@GOODBOY008
Copy link
Member Author

GOODBOY008 commented Oct 31, 2025

This pull request updates several GitHub Actions workflow files to restrict when certain jobs run, ensuring that scheduled or sensitive jobs only execute for the apache/fesod repository. This helps prevent unnecessary or unintended workflow runs on forks or other repositories.

Workflow job execution restrictions:

  • Added conditional execution to the codeql job in .github/workflows/codeql-scan.yml, so it only runs on schedule for the main repository or always for other event types.
  • Added conditional execution to the fuzz job in .github/workflows/fuzz-tests.yml, mirroring the logic used for the CodeQL job.
  • Added conditional execution to the nightly-test job in .github/workflows/nightly.yml, restricting scheduled runs to the main repository.

Repository-specific deployment and release:

  • Restricted the deploy job in .github/workflows/deploy-docs.yml to only run for the apache/fesod repository.
  • Restricted the publish job in .github/workflows/release.yml to only run for the apache/fesod repository.

@alaahong Can you read the description of pr carefully, I think it detailed the reason and effects.Thank you~

@alaahong
Copy link
Member

This pull request updates several GitHub Actions workflow files to restrict when certain jobs run, ensuring that scheduled or sensitive jobs only execute for the apache/fesod repository. This helps prevent unnecessary or unintended workflow runs on forks or other repositories.
Workflow job execution restrictions:

  • Added conditional execution to the codeql job in .github/workflows/codeql-scan.yml, so it only runs on schedule for the main repository or always for other event types.
  • Added conditional execution to the fuzz job in .github/workflows/fuzz-tests.yml, mirroring the logic used for the CodeQL job.
  • Added conditional execution to the nightly-test job in .github/workflows/nightly.yml, restricting scheduled runs to the main repository.

Repository-specific deployment and release:

  • Restricted the deploy job in .github/workflows/deploy-docs.yml to only run for the apache/fesod repository.
  • Restricted the publish job in .github/workflows/release.yml to only run for the apache/fesod repository.

@alaahong Can you read the description of pr carefully, I think it detailed the reason and effects.Thank you~

As I mentioned,

Seems all schedule checking are not required.
And meanwhile all changes in manual action are not required.
Please limited the repository condition only on schedule action.
  1. All your changed action with schedule checking are related to quality and no any additional token or cost, seems no mandatory reason to limited;
  2. for your limited action on deploy-docs and release, as they won't have the actual secret, seems no impact if not restrict
  3. this mean encourage to only keep the "github.repository == 'apache/fesod'" checking on codeql-scan, fuzz-tests and nightly even I think it's also not a mandatory changes as contributor have the possible to be alert by default quality validation in fork repo by default.

Please correct me if any out of your proposal, but quote again do not make the thing clearly~

@GOODBOY008
Copy link
Member Author

@alaahong Maybe we can learn from other projects like: Apache SkyWalking.

@psxjoy psxjoy self-requested a review October 31, 2025 15:40
Copy link
Member

@psxjoy psxjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psxjoy psxjoy enabled auto-merge (squash) October 31, 2025 15:42
@delei delei disabled auto-merge October 31, 2025 16:05
@alaahong alaahong dismissed their stale review November 1, 2025 13:44

Keep community opening for different view.

@psxjoy psxjoy merged commit 1e54c05 into apache:main Nov 1, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants