-
Notifications
You must be signed in to change notification settings - Fork 465
feat: add conditional triggers for workflows #664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It's good point to enhance the CI. |
|
Q1:The pr remove meanless schedule ci on fork repo, did not reduce this repo ci. Q2: Ditto. |
alaahong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems all schedule checking are not required.
And meanwhile all changes in manual action are not required.
Please limited the repository condition only on schedule action.
@alaahong Can you read the description of pr carefully, I think it detailed the reason and effects.Thank you~ |
As I mentioned,
Please correct me if any out of your proposal, but quote again do not make the thing clearly~ |
|
@alaahong Maybe we can learn from other projects like: Apache SkyWalking. |
psxjoy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Keep community opening for different view.
This pull request updates several GitHub Actions workflow files to restrict when certain jobs run, ensuring that scheduled or sensitive jobs only execute for the
apache/fesodrepository. This helps prevent unnecessary or unintended workflow runs on forks or other repositories.Workflow job execution restrictions:
codeqljob in.github/workflows/codeql-scan.yml, so it only runs on schedule for the main repository or always for other event types.fuzzjob in.github/workflows/fuzz-tests.yml, mirroring the logic used for the CodeQL job.nightly-testjob in.github/workflows/nightly.yml, restricting scheduled runs to the main repository.Repository-specific deployment and release:
deployjob in.github/workflows/deploy-docs.ymlto only run for theapache/fesodrepository.publishjob in.github/workflows/release.ymlto only run for theapache/fesodrepository.