-
Notifications
You must be signed in to change notification settings - Fork 469
refactor: rename and deprecate legacy core classes #688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
9d897e8
22f3090
73c919c
e364005
0dddc56
036b9df
d9f98ef
120c33f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -19,7 +19,315 @@ | |||||
|
|
||||||
| package org.apache.fesod.sheet; | ||||||
|
|
||||||
| import java.io.File; | ||||||
| import java.io.InputStream; | ||||||
| import java.io.OutputStream; | ||||||
| import org.apache.fesod.sheet.read.builder.ExcelReaderBuilder; | ||||||
| import org.apache.fesod.sheet.read.builder.ExcelReaderSheetBuilder; | ||||||
| import org.apache.fesod.sheet.read.listener.ReadListener; | ||||||
| import org.apache.fesod.sheet.write.builder.ExcelWriterBuilder; | ||||||
| import org.apache.fesod.sheet.write.builder.ExcelWriterSheetBuilder; | ||||||
| import org.apache.fesod.sheet.write.builder.ExcelWriterTableBuilder; | ||||||
|
|
||||||
| /** | ||||||
| * This is actually {@link FesodSheetFactory}, and short names look better. | ||||||
| * Core classes of the Fesod spreadsheet processor | ||||||
| */ | ||||||
| public class FesodSheet extends FesodSheetFactory {} | ||||||
| public class FesodSheet { | ||||||
|
|
||||||
| /** | ||||||
| * Build excel the write | ||||||
| * | ||||||
| * @return | ||||||
|
||||||
| * @return | |
| * @return Excel writer builder |
Copilot
AI
Nov 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing @return description in JavaDoc. The @return tag should include a description of what is returned (e.g., "Excel sheet reader builder").
| * @return | |
| * @return Excel sheet reader builder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove FesodSheetFactory as that's from factory pattern?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure a single core class. In fact, these two types are not much different and they can also avoid some of the checks and prompts in the IDE.