-
Notifications
You must be signed in to change notification settings - Fork 465
docs: Complete FastExcel to FesodSheet rename #694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @delei, just wondering if I should also include updates to the main README.md in this PR? I noticed it contains "Excel" references that should be changed to "spreadsheet" for consistency. Let me know what you think! |
Sure. Including modifying the |
Please modify the "description" in the |
|
Hi, @ongdisheng Are there any others that haven't been submitted yet? Is this PR ready to start the review process? FYI, We will accept the correction of this error by splitting it into multiple pull requests. Please feel free to submit the pull requests at any time. |
|
Hi @delei, all done and ready for review. Thanks for checking! |
delei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM

Related: #651 #691 (comment)
Purpose of the pull request
This PR fixes a couple of small issues in the website that were missed during the
FastExceltoFesodSheetrename in PR #691.What's changed?
The introduction page was using
Fesod.readinstead ofFesodSheet.readin the code example. The Chinese version already had this correct, so I updated the English version to match. I also replaced Excel with spreadsheet in the homepage to be consistent with the rest of the website. Thelarge-data.mdis also updated to be consistent with the Chinese version, keeping only Microsoft Excel 03 and Microsoft Excel 2007 when referring to the specific applications, while changing all other "Excel file" references to "spreadsheet file".Screenshot
Checklist