Skip to content

Conversation

@ongdisheng
Copy link
Contributor

@ongdisheng ongdisheng commented Nov 18, 2025

Related: #651 #691 (comment)

Purpose of the pull request

This PR fixes a couple of small issues in the website that were missed during the FastExcel to FesodSheet rename in PR #691.

What's changed?

The introduction page was using Fesod.read instead of FesodSheet.read in the code example. The Chinese version already had this correct, so I updated the English version to match. I also replaced Excel with spreadsheet in the homepage to be consistent with the rest of the website. The large-data.md is also updated to be consistent with the Chinese version, keeping only Microsoft Excel 03 and Microsoft Excel 2007 when referring to the specific applications, while changing all other "Excel file" references to "spreadsheet file".

Screenshot

image image

Checklist

  • I have read the Contributor Guide.
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

@ongdisheng
Copy link
Contributor Author

Hi @delei, just wondering if I should also include updates to the main README.md in this PR? I noticed it contains "Excel" references that should be changed to "spreadsheet" for consistency. Let me know what you think!

@delei
Copy link
Member

delei commented Nov 18, 2025

Hi @delei, just wondering if I should also include updates to the main README.md in this PR? I noticed it contains "Excel" references that should be changed to "spreadsheet" for consistency. Let me know what you think!

Sure. Including modifying the Fesod in the sample code.

@delei delei self-requested a review November 18, 2025 15:25
@ongdisheng ongdisheng changed the title docs: Complete FastExcel to FesodSheet rename in website docs: Complete FastExcel to FesodSheet rename Nov 18, 2025
@ongdisheng
Copy link
Contributor Author

Just wanted to mention that I noticed the repository's About section still says "Processing Excels" instead of "spreadsheets". I don't have permission to update it myself, but wanted to bring it up in case it should be changed for consistency.
image

@delei
Copy link
Member

delei commented Nov 18, 2025

Just wanted to mention that I noticed the repository's About section still says "Processing Excels" instead of "spreadsheets". I don't have permission to update it myself, but wanted to bring it up in case it should be changed for consistency.

Please modify the "description" in the .asf.yaml file.

@delei
Copy link
Member

delei commented Nov 18, 2025

Hi, @ongdisheng

Are there any others that haven't been submitted yet? Is this PR ready to start the review process?

FYI, We will accept the correction of this error by splitting it into multiple pull requests. Please feel free to submit the pull requests at any time.

@ongdisheng
Copy link
Contributor Author

Hi @delei, all done and ready for review. Thanks for checking!

Copy link
Member

@delei delei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delei delei merged commit bdd19c2 into apache:main Nov 18, 2025
10 checks passed
@ongdisheng ongdisheng deleted the docs/fix-website-rename-issues branch November 18, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants