-
Notifications
You must be signed in to change notification settings - Fork 489
fix: Use GitHub Actions for markdown linting in ci-docs
#718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4f05a69
fix: Use actions for markdownlint
ongdisheng fbcdfd5
fix: Remove globs from markdownlint config to only lint changed files
ongdisheng f053f87
fix: Update markdown filter to match nested files
ongdisheng cba5a2f
refactor: Lint all markdown files
ongdisheng 98d057e
refactor: Update globs to lint all markdown files in website folder
ongdisheng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @delei, currently
ci-docsonly triggers onwebsite/**changes. Should we also add.github/workflows/ci-docs.ymlto the paths so the workflow runs when we modify it? I feel it's better safe than sorry as when someone changes this workflow file, we might want to test theci-docsworkflow again to make sure it still works correctly. Just wondering what you think about this?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typically, we do not include modifications within the
.githubdirectory as part of CI process.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, will keep it as current version. Thanks for clarifying!