refactor: Remove @EqualsAndHashCode annotation from AnalysisCell class#723
Merged
psxjoy merged 1 commit intoapache:mainfrom Dec 4, 2025
Merged
refactor: Remove @EqualsAndHashCode annotation from AnalysisCell class#723psxjoy merged 1 commit intoapache:mainfrom
psxjoy merged 1 commit intoapache:mainfrom
Conversation
GOODBOY008
force-pushed
the
feature/fix-lombok
branch
from
98fe0d2 to
b0a5f6b
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request removes the @EqualsAndHashCode Lombok annotation from the AnalysisCell class to address Lombok configuration issues. The class already has manual equals() and hashCode() method implementations, making the annotation redundant.
Key Changes:
- Removed the
@EqualsAndHashCodeannotation from the class declaration, eliminating redundancy with the existing manual implementations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Fix Lombok configuration issues by removing unnecessary
@EqualsAndHashCodeannotation from AnalysisCell class.What's changed?
@EqualsAndHashCodeannotation fromAnalysisCellclass infesod/src/main/java/org/apache/fesod/sheet/write/metadata/fill/AnalysisCell.javaChecklist