Skip to content

FINERACT-2311: Add Buy Down Fees transaction support#4790

Merged
adamsaghy merged 1 commit intoapache:developfrom
openMF:FINERACT-2311/buy-down-fees-template-api
Jul 8, 2025
Merged

FINERACT-2311: Add Buy Down Fees transaction support#4790
adamsaghy merged 1 commit intoapache:developfrom
openMF:FINERACT-2311/buy-down-fees-template-api

Conversation

@alberto-art3ch
Copy link
Contributor

Description

As part of creating a Buy Down Fee transaction, the template call for this transaction should retrieve the maximum allowed amount:

Formula:
Maximum allowed amount = Approved amount of the loan - total disbursed amount - total buy down fees - total capitalized income

FINERACT-2311

Screenshot 2025-06-19 at 9 09 46 p m

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@budaidev budaidev force-pushed the FINERACT-2311/buy-down-fees-template-api branch 2 times, most recently from a07fa95 to d2622b0 Compare June 20, 2025 19:36
@alberto-art3ch alberto-art3ch force-pushed the FINERACT-2311/buy-down-fees-template-api branch from d2622b0 to 2ed87ee Compare June 22, 2025 05:24
@adamsaghy
Copy link
Contributor

@alberto-art3ch

  Test givenMissingEventConfigurationWhenValidatedThenThrowException() FAILED

  org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
      at app//org.apache.fineract.infrastructure.event.external.service.ExternalEventConfigurationValidationServiceTest.givenMissingEventConfigurationWhenValidatedThenThrowException(ExternalEventConfigurationValidationServiceTest.java:221)

@alberto-art3ch alberto-art3ch force-pushed the FINERACT-2311/buy-down-fees-template-api branch 3 times, most recently from 736badd to 74cb572 Compare June 23, 2025 02:50
@adamsaghy
Copy link
Contributor

@alberto-art3ch Please rebase

Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks much more than "adding Buy Down fee template API"

@alberto-art3ch alberto-art3ch force-pushed the FINERACT-2311/buy-down-fees-template-api branch from 74cb572 to f213169 Compare June 26, 2025 16:09
@alberto-art3ch alberto-art3ch changed the title FINERACT-2311: Buy Down Fees template transaction FINERACT-2311: Add Buy Down Fees transaction support Jun 26, 2025
@alberto-art3ch alberto-art3ch force-pushed the FINERACT-2311/buy-down-fees-template-api branch 2 times, most recently from 71d6585 to 9cb6c33 Compare June 26, 2025 18:30
Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks way bigger than simply adding template API for Buy down transaction

@alberto-art3ch alberto-art3ch force-pushed the FINERACT-2311/buy-down-fees-template-api branch 3 times, most recently from 4e232ea to 32808ac Compare July 4, 2025 19:05
Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alberto-art3ch alberto-art3ch force-pushed the FINERACT-2311/buy-down-fees-template-api branch 2 times, most recently from 6cd3d6b to 508a42e Compare July 7, 2025 19:38
@adamsaghy adamsaghy force-pushed the FINERACT-2311/buy-down-fees-template-api branch 5 times, most recently from 7b4b742 to cbe5951 Compare July 8, 2025 10:52
@adamsaghy adamsaghy force-pushed the FINERACT-2311/buy-down-fees-template-api branch from cbe5951 to 0e7791f Compare July 8, 2025 11:16
@adamsaghy adamsaghy merged commit 5310822 into apache:develop Jul 8, 2025
39 checks passed
@adamsaghy adamsaghy deleted the FINERACT-2311/buy-down-fees-template-api branch July 8, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants