FINERACT-2311: Add Buy Down Fees transaction support#4790
Merged
adamsaghy merged 1 commit intoapache:developfrom Jul 8, 2025
Merged
FINERACT-2311: Add Buy Down Fees transaction support#4790adamsaghy merged 1 commit intoapache:developfrom
adamsaghy merged 1 commit intoapache:developfrom
Conversation
a07fa95 to
d2622b0
Compare
d2622b0 to
2ed87ee
Compare
Contributor
|
736badd to
74cb572
Compare
Contributor
|
@alberto-art3ch Please rebase |
adamsaghy
requested changes
Jun 25, 2025
Contributor
adamsaghy
left a comment
There was a problem hiding this comment.
This PR looks much more than "adding Buy Down fee template API"
74cb572 to
f213169
Compare
71d6585 to
9cb6c33
Compare
adamsaghy
requested changes
Jun 30, 2025
Contributor
adamsaghy
left a comment
There was a problem hiding this comment.
This PR looks way bigger than simply adding template API for Buy down transaction
4e232ea to
32808ac
Compare
6cd3d6b to
508a42e
Compare
7b4b742 to
cbe5951
Compare
cbe5951 to
0e7791f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As part of creating a Buy Down Fee transaction, the template call for this transaction should retrieve the maximum allowed amount:
Formula:
Maximum allowed amount = Approved amount of the loan - total disbursed amount - total buy down fees - total capitalized income
FINERACT-2311
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.