Skip to content

FINERACT-2318: add LoanApplicationModifiedBusinessEvent & LoanWithdrawnByApplicantBusinessEvent#4809

Merged
adamsaghy merged 1 commit intoapache:developfrom
JebronLames32:LoanEventFeature
Jul 4, 2025
Merged

FINERACT-2318: add LoanApplicationModifiedBusinessEvent & LoanWithdrawnByApplicantBusinessEvent#4809
adamsaghy merged 1 commit intoapache:developfrom
JebronLames32:LoanEventFeature

Conversation

@JebronLames32
Copy link
Contributor

Description

At the moment, events are emitted for Loan application creation, approval, rejection, charge adjustment, and many others, but does not emit an event when

  1. a loan application in SUBMITTED_AND_PENDING_APPROVAL state is modified (e.g. loan amount or term updated)
  2. a loan application is withdrawn by the applicant before approval. An external service can get to know that the application has been withdrawn through the LoanStatusChangedBusinessEvent but unlike approval, rejection, and creation, it does not have an event of its own

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@adamsaghy
Copy link
Contributor

@JebronLames32 Please rebase your PR to resolve the conflicts!

@JebronLames32
Copy link
Contributor Author

@adamsaghy rebased!

@JebronLames32
Copy link
Contributor Author

JebronLames32 commented Jul 4, 2025

@adamsaghy request you to please review so I can avoid merge conflicts again. Thanks!

@adamsaghy adamsaghy merged commit a591f26 into apache:develop Jul 4, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants