Skip to content

Conversation

@oleksii-novikov-onix
Copy link
Contributor

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oleksii-novikov-onix oleksii-novikov-onix force-pushed the FINERACT-1926/asset-owner-event-changes branch 5 times, most recently from a27b261 to c2b2992 Compare August 8, 2025 09:50
@oleksii-novikov-onix oleksii-novikov-onix marked this pull request as ready for review August 14, 2025 18:47
@oleksii-novikov-onix oleksii-novikov-onix marked this pull request as draft August 14, 2025 18:50
@oleksii-novikov-onix oleksii-novikov-onix force-pushed the FINERACT-1926/asset-owner-event-changes branch from 8347ef3 to e2e1cf2 Compare August 18, 2025 08:23
@adamsaghy adamsaghy marked this pull request as ready for review August 18, 2025 08:23
@oleksii-novikov-onix oleksii-novikov-onix force-pushed the FINERACT-1926/asset-owner-event-changes branch 3 times, most recently from 3aa748e to 96ea87c Compare August 20, 2025 11:20
@MarianaDmytrivBinariks MarianaDmytrivBinariks force-pushed the FINERACT-1926/asset-owner-event-changes branch from 96ea87c to 20f6886 Compare August 20, 2025 11:32
@oleksii-novikov-onix oleksii-novikov-onix force-pushed the FINERACT-1926/asset-owner-event-changes branch from 20f6886 to 3e05fff Compare August 20, 2025 11:47
@MarianaDmytrivBinariks MarianaDmytrivBinariks force-pushed the FINERACT-1926/asset-owner-event-changes branch 7 times, most recently from 924d034 to 8526169 Compare August 21, 2025 10:02
@MarianaDmytrivBinariks MarianaDmytrivBinariks force-pushed the FINERACT-1926/asset-owner-event-changes branch from 8526169 to 55c4d64 Compare August 21, 2025 10:43
@adamsaghy adamsaghy merged commit 5b638c6 into apache:develop Aug 21, 2025
39 checks passed
@adamsaghy adamsaghy deleted the FINERACT-1926/asset-owner-event-changes branch August 21, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants