Skip to content

Conversation

@adamsaghy
Copy link
Contributor

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@adamsaghy adamsaghy changed the title FINERACT-2326: Use Hibernate Validator FINERACT-2326: Use Hibernate Validator + Fix Business date validation Aug 18, 2025
@adamsaghy adamsaghy force-pushed the FINERACT-2326/use-hibernate-validation branch from f0e290c to d52bc9d Compare August 18, 2025 11:39
@adamsaghy adamsaghy changed the title FINERACT-2326: Use Hibernate Validator + Fix Business date validation FINERACT-2326: Use Hibernate Validator + Rework Business date validation Aug 18, 2025
@adamsaghy adamsaghy force-pushed the FINERACT-2326/use-hibernate-validation branch from 7c26ba6 to d52bc9d Compare August 18, 2025 11:43
@adamsaghy adamsaghy changed the title FINERACT-2326: Use Hibernate Validator + Rework Business date validation FINERACT-2326: Use Hibernate Validator Aug 18, 2025
@adamsaghy adamsaghy force-pushed the FINERACT-2326/use-hibernate-validation branch from d52bc9d to 898de9a Compare August 18, 2025 11:52
@adamsaghy adamsaghy force-pushed the FINERACT-2326/use-hibernate-validation branch from 898de9a to e9e3d81 Compare August 18, 2025 12:15
@adamsaghy adamsaghy merged commit 77f7d9a into apache:develop Aug 18, 2025
48 of 49 checks passed
@adamsaghy
Copy link
Contributor Author

@VictorPavfurious @vidakovic FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants