Skip to content

FINERACT-2421: Fix GRETERTHAN typo in ConditionType enum #5281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamsaghy merged 1 commit into from
Jan 12, 2026
Merged

FINERACT-2421: Fix GRETERTHAN typo in ConditionType enum #5281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions fineract-core/src/main/java/org/apache/fineract/portfolio/common/domain/ConditionType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@ public enum ConditionType {
INVALID(0, "ConditionType.invalid"), //
LESSTHAN(1, "ConditionType.lessthan"), //
EQUAL(2, "ConditionType.equal"), //
// TODO: fix typo "GREATERTHAN"
GRETERTHAN(3, "ConditionType.greterthan"), //
GREATERTHAN(3, "ConditionType.greaterthan"), //
NOT_EQUAL(4, "ConditionType.notequal");//

private final Integer value;
Expand All @@ -43,7 +42,7 @@ public static ConditionType fromInt(final Integer v) {
case 2:
return EQUAL;
case 3:
return GRETERTHAN;
return GREATERTHAN;
case 4:
return NOT_EQUAL;
default:
Expand Down
6 changes: 3 additions & 3 deletions ...t-core/src/main/java/org/apache/fineract/portfolio/common/service/CommonEnumerations.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,9 @@ public static EnumOptionData conditionType(final ConditionType type, final Strin
optionData = new EnumOptionData(ConditionType.NOT_EQUAL.getValue().longValue(),
codePrefix + ConditionType.NOT_EQUAL.getCode(), "notEqual");
break;
case GRETERTHAN:
optionData = new EnumOptionData(ConditionType.GRETERTHAN.getValue().longValue(),
codePrefix + ConditionType.GRETERTHAN.getCode(), "greterthan");
case GREATERTHAN:
optionData = new EnumOptionData(ConditionType.GREATERTHAN.getValue().longValue(),
codePrefix + ConditionType.GREATERTHAN.getCode(), "greaterthan");
break;
case LESSTHAN:
optionData = new EnumOptionData(ConditionType.LESSTHAN.getValue().longValue(),
Expand Down
2 changes: 1 addition & 1 deletion ...in/java/org/apache/fineract/portfolio/common/service/DropdownReadPlatformServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public List<EnumOptionData> retrievePeriodFrequencyTypeOptions() {
@Override
public List<EnumOptionData> retrieveConditionTypeOptions() {
return Arrays.asList(conditionType(ConditionType.EQUAL, "condition"), conditionType(ConditionType.NOT_EQUAL, "condition"),
conditionType(ConditionType.GRETERTHAN, "condition"), conditionType(ConditionType.LESSTHAN, "condition"));
conditionType(ConditionType.GREATERTHAN, "condition"), conditionType(ConditionType.LESSTHAN, "condition"));
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion .../apache/fineract/portfolio/interestratechart/incentive/AttributeIncentiveCalculation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public boolean applyIncentive(ConditionType conditionType, Long attributeValue,
case NOT_EQUAL:
applyIncentive = compareVal != 0;
break;
case GRETERTHAN:
case GREATERTHAN:
applyIncentive = compareVal > 0;
break;
default:
Expand Down
Loading