FINERACT-1266: Fix NullPointerException in SavingsHelper.determineInterestPostingPeriods #5282
+5
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes NullPointerException that occurs in
SavingsHelper.determineInterestPostingPeriods()when date parameters are null.The NPE occurs when closing a Fixed Deposit account if the maturity date is null (e.g., when
depositPeriodFrequencyTypeis INVALID).Root Cause
The method
determineInterestPostingPeriods()usesDateUtils.isAfter()which throws NPE when eitherstartInterestCalculationLocalDateorinterestPostingUpToDateis null.Fix
Added null check at the start of the method to return an empty list early if either date parameter is null.
Testing
Related Issue
Fixes FINERACT-1266