FINERACT-2320: Return false instead of throwing exception when LOAN_COB is disabled #5283
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the error "Job LOAN_COB is not found or it is disabled" that appears when navigating to Manage Jobs with LOAN_COB disabled.
Root Cause
When
fineract.job.loan-cob-enabled=false, the/api/v1/loans/is-catch-up-runningendpoint throwsJobIsNotFoundOrNotEnabledException, which maps to HTTP 403 Forbidden.Fix
Changed the
isCatchUpRunning()method to return a defaultIsCatchUpRunningDTO(false, null)when the service is not available, instead of throwing an exception.Before:
After:
Related Issue
Fixes FINERACT-2320