FINERACT-2434: Add input validation to split-tests.sh script #5296
+15
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Please add this Jira Ticket on the commit and the PR "FINERACT-2434" |
Farhantigadi
force-pushed
the
feature/split-tests-args-validation
branch
from
d1cfa86 to
99a0f3d
Compare
Farhantigadi
changed the title
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The split-tests.sh script currently only checks if arguments are provided but doesn't validate their values. This can lead to confusing behavior when users pass invalid inputs like negative numbers, zero, or non-numeric values.
This change adds basic input validation to make the script more robust and user-friendly. Now when someone runs the script with invalid arguments (like ./split-tests.sh 0 5 or ./split-tests.sh 3 abc), they'll get a clear error message explaining what went wrong instead of the script failing mysteriously later.
The validation ensures:
Both arguments are positive integers (no zero, negative, or text values)
The shard index doesn't exceed the total number of shards
Users get helpful error messages when something is wrong
This is a small improvement that makes the script safer and easier to use, especially for new contributors who might not be familiar with the expected input format.