FINERACT-2464: Refactor LoanScheduleAssembler logic extraction#5438
Open
Saifulhuq01 wants to merge 1 commit intoapache:developfrom
Open
FINERACT-2464: Refactor LoanScheduleAssembler logic extraction#5438Saifulhuq01 wants to merge 1 commit intoapache:developfrom
Saifulhuq01 wants to merge 1 commit intoapache:developfrom
Conversation
Saifulhuq01
force-pushed
the
refactor-loan-schedule-logic-v2
branch
from
436d78e to
328f07e
Compare
adamsaghy
reviewed
Feb 6, 2026
|
|
||
| LoanScheduleGenerator loanScheduleGenerator = this.loanScheduleFactory.create(loanApplicationTerms.getLoanScheduleType(), | ||
| loanApplicationTerms.getInterestMethod()); | ||
| // REFACTORED: Removed redundant initialization and extracted logic |
Contributor
There was a problem hiding this comment.
We dont want such comments. Please remove
Contributor
Author
There was a problem hiding this comment.
We dont want such comments. Please remove
done @adamsaghy kindly check
Saifulhuq01
force-pushed
the
refactor-loan-schedule-logic-v2
branch
from
328f07e to
ee1e058
Compare
Saifulhuq01
force-pushed
the
refactor-loan-schedule-logic-v2
branch
from
ee1e058 to
3ea2678
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactored LoanScheduleAssembler.java to improve code readability and maintainability extracting inline logic into a helper method.
Currently, the assembleLoanScheduleFrom method contains mixed logic for creating the
LoanScheduleGeneratorand handling "Equal Amortization" updates. This violates the Single Responsibility Principle and increases cogniive load.Resolves FINERACT-2464.
Changes
loanScheduleGenerator.Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!