FINERACT-2481: Remove Pentaho reports from initial sample data#5491
FINERACT-2481: Remove Pentaho reports from initial sample data#5491AshharAhmadKhan wants to merge 1 commit intoapache:developfrom
Conversation
|
@AshharAhmadKhan I think that it is better to add a new liquibase migration file, so then we can track the historical changes |
5271dc9 to
ebe9a82
Compare
|
@IOhacker Thank you for the feedback! I've updated the PR to include a Liquibase migration file as requested. Changes made:
The Liquibase migration ensures existing installations are cleaned up, while the sample data changes prevent new installations from including these legacy Pentaho entries. Ready for re-review! |
ebe9a82 to
9b9bcf2
Compare
|
@AshharAhmadKhan run ./gradlew :spotlessApply and squash and commit your changes (only 1 commit per PR) |
cdbfc51 to
6293e50
Compare
IOhacker
left a comment
There was a problem hiding this comment.
Exclude the sample_data sql files from this PR
6293e50 to
7bff1d8
Compare
|
@IOhacker Updated as requested! Changes made: The migration now handles:
Ready for review! |
Remove deprecated Pentaho report entries from initial data using Liquibase migration. Changes: - Added migration 0210_remove_pentaho_reports.xml with explicit report names - Deletes 26 Pentaho permission entries from m_permission table - Deletes 44 Pentaho report entries from stretchy_report table - Handles child table (stretchy_report_parameter) before parent deletion - Uses case-insensitive matching for cross-database compatibility The migration includes preConditions to safely handle cases where Pentaho data has already been removed, ensuring idempotent execution.
7bff1d8 to
d4108f6
Compare
Remove deprecated Pentaho reports from initial sample data
Description
This PR removes all deprecated Pentaho report and permission entries from the initial sample data SQL files used by new Apache Fineract installations.
Pentaho is being phased out in favor of newer reporting mechanisms. Keeping these entries in sample data provides no value and introduces legacy artifacts into fresh deployments.
This change is intentionally limited to initial data only and does not affect runtime behavior or existing installations.
Changes
m_permissiontablestretchy_reporttablebarebones_db.sqlload_sample_data.sqlImpact & Risk Analysis
m_report_mailing_jobcontains zero rows referencingstretchy_reportVerification
Checklist
Addresses FINERACT-2481