Skip to content

FINERACT-2481: Remove Pentaho reports from initial sample data#5491

Open
AshharAhmadKhan wants to merge 1 commit intoapache:developfrom
AshharAhmadKhan:FINERACT-2481-remove-pentaho-initial-data
Open

FINERACT-2481: Remove Pentaho reports from initial sample data#5491
AshharAhmadKhan wants to merge 1 commit intoapache:developfrom
AshharAhmadKhan:FINERACT-2481-remove-pentaho-initial-data

Conversation

@AshharAhmadKhan
Copy link

@AshharAhmadKhan AshharAhmadKhan commented Feb 13, 2026

Remove deprecated Pentaho reports from initial sample data

Description

This PR removes all deprecated Pentaho report and permission entries from the initial sample data SQL files used by new Apache Fineract installations.

Pentaho is being phased out in favor of newer reporting mechanisms. Keeping these entries in sample data provides no value and introduces legacy artifacts into fresh deployments.

This change is intentionally limited to initial data only and does not affect runtime behavior or existing installations.

Changes

  • Removed 27 Pentaho-related permission entries from the m_permission table
  • Removed 43 Pentaho report entries from the stretchy_report table
  • Applied changes consistently to:
    • barebones_db.sql
    • load_sample_data.sql

Impact & Risk Analysis

  • No impact on existing installations
    • No schema changes
    • No database migrations
    • No deletions on live databases
  • No foreign key violations
    • Verified that m_report_mailing_job contains zero rows referencing stretchy_report
  • Scope strictly limited to initial data for new deployments

Verification

# Confirmed no remaining Pentaho references
grep -c "Pentaho" barebones_db.sql        # 0
grep -c "Pentaho" load_sample_data.sql   # 0

Checklist

  • Commit message follows project guidelines
  • Build passes (no code or runtime changes)
  • Tests N/A – static SQL sample data only
  • API/Swagger updates N/A – no API or behavior changes
  • PR size within project limits

Addresses FINERACT-2481

@IOhacker
Copy link
Contributor

@AshharAhmadKhan I think that it is better to add a new liquibase migration file, so then we can track the historical changes

Copy link
Contributor

@IOhacker IOhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly see my comments

@AshharAhmadKhan AshharAhmadKhan force-pushed the FINERACT-2481-remove-pentaho-initial-data branch from 5271dc9 to ebe9a82 Compare February 15, 2026 05:01
@AshharAhmadKhan
Copy link
Author

@IOhacker Thank you for the feedback! I've updated the PR to include a Liquibase migration file as requested.

Changes made:

  • ✅ Added migration file: 0210_remove_pentaho_reports.xml
  • ✅ Included in changelog-tenant.xml
  • ✅ Deletes 26 Pentaho permission entries from m_permission table
  • ✅ Deletes 44 Pentaho report entries from stretchy_report table
  • ✅ Kept the sample data changes for new installations

The Liquibase migration ensures existing installations are cleaned up, while the sample data changes prevent new installations from including these legacy Pentaho entries.

Ready for re-review!

@AshharAhmadKhan AshharAhmadKhan force-pushed the FINERACT-2481-remove-pentaho-initial-data branch from ebe9a82 to 9b9bcf2 Compare February 15, 2026 05:40
@IOhacker
Copy link
Contributor

@AshharAhmadKhan run ./gradlew :spotlessApply and squash and commit your changes (only 1 commit per PR)

@AshharAhmadKhan AshharAhmadKhan force-pushed the FINERACT-2481-remove-pentaho-initial-data branch from cdbfc51 to 6293e50 Compare February 15, 2026 12:17
Copy link
Contributor

@IOhacker IOhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exclude the sample_data sql files from this PR

@AshharAhmadKhan
Copy link
Author

@IOhacker Updated as requested!

Changes made:
✅ Removed sample_data SQL files (barebones_db.sql and load_sample_data.sql)
✅ Kept only Liquibase migration approach
✅ Single commit with GPG signature
✅ Spotless applied successfully
✅ Used explicit report names in migration (26 permissions + 44 reports)

The migration now handles:

  • Child table deletion first (stretchy_report_parameter)
  • Explicit listing of all 26 Pentaho permission codes
  • Explicit listing of all 44 Pentaho report names
  • PreConditions for idempotent execution
  • Cross-database compatibility with LOWER() functions

Ready for review!

Remove deprecated Pentaho report entries from initial data using Liquibase migration.

Changes:
- Added migration 0210_remove_pentaho_reports.xml with explicit report names
- Deletes 26 Pentaho permission entries from m_permission table
- Deletes 44 Pentaho report entries from stretchy_report table
- Handles child table (stretchy_report_parameter) before parent deletion
- Uses case-insensitive matching for cross-database compatibility

The migration includes preConditions to safely handle cases where
Pentaho data has already been removed, ensuring idempotent execution.
@AshharAhmadKhan AshharAhmadKhan force-pushed the FINERACT-2481-remove-pentaho-initial-data branch from 7bff1d8 to d4108f6 Compare February 16, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants