This repository was archived by the owner on Feb 19, 2025. It is now read-only.
Adding appId #404
Closed
Adding appId #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@Jyyjy Tagging you for review |
Contributor
|
I don't think this field is meaningfully different than toolName. Other than requiring the user to specify it. If there is a difference, can we make that clear in the read me (and fix tests)? And if not, should this PR be to make toolname required? |
Contributor
|
Besides the fact I hate having a field entitled @r2o3k Can you simply make toolName and toolVersion mandatory fields like you have here with appId and we'll drop appId for now? And we need to fix the tests too. |
Contributor
|
Closing since this is covered by #411 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.