doc : add ElasticsearchVectorStore doc #397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
priority/major
|
@twosom Please add the following content to your PR description and select a checkbox: |
twosom
force-pushed
the
doc-elasticsearch-vectorstore
branch
from
3e293e7 to
27bd922
Compare
github-actions
bot
added
doc-not-needed
xintongsong
reviewed
Dec 27, 2025
Contributor
Author
|
Thank you for the review. I will update the PR today. |
twosom
force-pushed
the
doc-elasticsearch-vectorstore
branch
from
82ad3d6 to
81d31f1
Compare
xintongsong
reviewed
Jan 7, 2026
Contributor
xintongsong
left a comment
xintongsong
left a comment
There was a problem hiding this comment.
Thanks for addressing my comments, @twosom. The PR looks quite nice. I just have a few minor comments. Please take a look.
Co-authored-by: Xintong Song <[email protected]>
This reverts commit 615a5bc.
xintongsong
approved these changes
Jan 12, 2026
Contributor
xintongsong
left a comment
xintongsong
left a comment
There was a problem hiding this comment.
Thanks for addressing my comments. LGTM
xintongsong
added
doc-included
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issue: #385, #321
Purpose of change
Added documentation for ElasticsearchVectorStore.
Tests
API
Documentation
doc-neededdoc-not-needed