[api][runtime][java] Introduce Long-Term Memory. #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
priority/major
wenjin272
force-pushed
the
ltm-java-1
branch
3 times, most recently
from
af45357 to
83c1c9d
Compare
yanand0909
reviewed
Jan 10, 2026
Collaborator
yanand0909
left a comment
yanand0909
left a comment
There was a problem hiding this comment.
Thanks @wenjin272! Mostly looks good, I have added few comments.
...on/src/test/java/org/apache/flink/agents/integration/test/VectorStoreLongTermMemoryTest.java
Outdated
Show resolved
Hide resolved
runtime/src/main/java/org/apache/flink/agents/runtime/memory/CompactionFunctions.java
Outdated
Show resolved
Hide resolved
runtime/src/main/java/org/apache/flink/agents/runtime/memory/CompactionFunctions.java
Outdated
Show resolved
Hide resolved
runtime/src/main/java/org/apache/flink/agents/runtime/memory/CompactionFunctions.java
Outdated
Show resolved
Hide resolved
runtime/src/main/java/org/apache/flink/agents/runtime/memory/VectorStoreLongTermMemory.java
Show resolved
Hide resolved
runtime/src/main/java/org/apache/flink/agents/runtime/memory/VectorStoreLongTermMemory.java
Show resolved
Hide resolved
runtime/src/main/java/org/apache/flink/agents/runtime/memory/VectorStoreLongTermMemory.java
Show resolved
Hide resolved
runtime/src/main/java/org/apache/flink/agents/runtime/memory/VectorStoreLongTermMemory.java
Outdated
Show resolved
Hide resolved
runtime/src/main/java/org/apache/flink/agents/runtime/memory/VectorStoreLongTermMemory.java
Show resolved
Hide resolved
xintongsong
reviewed
Jan 12, 2026
api/src/main/java/org/apache/flink/agents/api/memory/BaseLongTermMemory.java
Outdated
Show resolved
Hide resolved
runtime/src/main/java/org/apache/flink/agents/runtime/memory/VectorStoreLongTermMemory.java
Outdated
Show resolved
Hide resolved
runtime/src/main/java/org/apache/flink/agents/runtime/memory/VectorStoreLongTermMemory.java
Show resolved
Hide resolved
runtime/src/main/java/org/apache/flink/agents/runtime/memory/CompactionFunctions.java
Show resolved
Hide resolved
xintongsong
approved these changes
Jan 12, 2026
Contributor
xintongsong
left a comment
xintongsong
left a comment
There was a problem hiding this comment.
LGTM.
@yanand0909 , please let me know when all your concerns are addressed, and I'll merge the PR then.
Collaborator
|
Thanks for addressing my comments @wenjin272! Looks good to me @xintongsong |
yanand0909
approved these changes
Jan 12, 2026
xintongsong
force-pushed
the
ltm-java-1
branch
from
4dd1509 to
82c678a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issue: #349
Purpose of change
Introduce Long-Term Memory in Java.
Tests
ut & e2e
API
Yes, add Long-Term Memory interfaces in java.
Documentation
doc-neededdoc-not-neededdoc-included