-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[BP-3.2][docs] Update download links to up-to-date cdc version #3765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BP-3.2][docs] Update download links to up-to-date cdc version #3765
Conversation
611abd7 to
002fe3d
Compare
Signed-off-by: yuxiqian <[email protected]>
002fe3d to
0a88d4e
Compare
Signed-off-by: yuxiqian <[email protected]>
Signed-off-by: yuxiqian <[email protected]>
Signed-off-by: yuxiqian <[email protected]>
| }, | ||
| { | ||
| "pattern": "^https://repo1.maven.org/maven2/org/apache/flink.*SNAPSHOT.*" | ||
| "pattern": "^https://repo1.maven.org/maven2/org/apache/flink.*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yuxiqian SNAPSHOT version should not be available,but released version should be available. So can you explain the reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, CDC CI uses markdown-link-check to validate dead links and Hugo project to generate static websites.
Interpolated URL links like https://repo1.maven.org/maven2/org/apache/flink/flink-sql-connector-db2-cdc/{{< param Version >}}/flink-sql-connector-db2-cdc-{{< param Version >}}.jar are replaced to valid link when Hugo compiles it, but markdown-link-check doesn't understand it and will trigger a false alarm.
I also agree that silencing all maven link checks isn't very ideal. Any suggestions on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I get it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick response. Mind you also take a look at #3766 that fixes this in the master branch?
Use parameterized version string instead of write hard-encoded links.