Skip to content

Conversation

@yuxiqian
Copy link
Member

Use parameterized version string instead of write hard-encoded links.

@github-actions github-actions bot added docs Improvements or additions to documentation build labels Nov 27, 2024
@yuxiqian yuxiqian changed the title [docs] Update download links to up-to-date cdc version [BP-3.2][docs] Update download links to up-to-date cdc version Nov 27, 2024
@yuxiqian yuxiqian force-pushed the docs/bump-download-links-bp-3.2 branch from 611abd7 to 002fe3d Compare November 27, 2024 10:08
@yuxiqian yuxiqian force-pushed the docs/bump-download-links-bp-3.2 branch from 002fe3d to 0a88d4e Compare November 27, 2024 10:12
@github-actions github-actions bot removed the build label Nov 27, 2024
@yuxiqian yuxiqian closed this Nov 27, 2024
@yuxiqian yuxiqian reopened this Nov 27, 2024
},
{
"pattern": "^https://repo1.maven.org/maven2/org/apache/flink.*SNAPSHOT.*"
"pattern": "^https://repo1.maven.org/maven2/org/apache/flink.*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuxiqian SNAPSHOT version should not be available,but released version should be available. So can you explain the reason?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, CDC CI uses markdown-link-check to validate dead links and Hugo project to generate static websites.

Interpolated URL links like https://repo1.maven.org/maven2/org/apache/flink/flink-sql-connector-db2-cdc/{{< param Version >}}/flink-sql-connector-db2-cdc-{{< param Version >}}.jar are replaced to valid link when Hugo compiles it, but markdown-link-check doesn't understand it and will trigger a false alarm.

I also agree that silencing all maven link checks isn't very ideal. Any suggestions on this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I get it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick response. Mind you also take a look at #3766 that fixes this in the master branch?

@GOODBOY008 GOODBOY008 merged commit 3017e14 into apache:release-3.2 Dec 7, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants