[FLINK-36805][cdc-common] Add ConfigShade interface to support encryption of sensitive configuration items and provide a base64 encoding implementation#3829
Open
Jzjsnow wants to merge 3 commits intoapache:masterfrom
Conversation
fcb28d0 to
125d039
Compare
125d039 to
592a81f
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 60 days if no further activity occurs. |
joyCurry30
reviewed
May 19, 2025
Contributor
joyCurry30
left a comment
There was a problem hiding this comment.
Nice contribution. Could you please add a test case where the configuration value contains sensitive words?
…itive configuration items and provide base64 encoding implementation
…of sensitive configuration items and provide base64 encoding implementation
592a81f to
7f0e3ad
Compare
Contributor
Author
@joyCurry30 Ok, I've added a test to verify that yaml can be parsed and decrypted correctly when the configuration value contains sensitive keywords. PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduction
When Flink CDC uses pipeline to submit jobs, we need to set configuration items in plaintext in the definition file, including sensitive configurations such as passwords for connecting to source and sink components (e.g., mysql, doris, etc.), which may be a security risk. To avoid the use of plaintext passwords, we provide an interface (ConfigShade) by implementing which developers can customize the decryption method themselves.
We also provide an implementation for base64 encoding first, not only as an example implementation of the interface, but also to solve the current problem of plaintext passwords.
How to use
Using the base64 implementation as an example, the following shows how to use a configuration file with sensitive items encrypted:
shade.identifierandshade.sensitive.keywordsto thepipelinepart in the definition yaml file to specify the encryption algorithm and the encrypted sensitive keywords.shade.sensitive.keywordswith the encrypted ciphertext.Example definition file:
How to customize the encryption algorithm
To use a user-defined encryption algorithm, we expect the developer to provide a dependency package that implements the
ConfigShadeinterface.In it, the method
getIdentifier()can be called to get the unique identifier of the algorithm, which is used to configure theshade.identifier, and the methoddecrypt(String content)can be used to decrypt the input cipher text.