-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[FLINK-37203] Alter table comment or column comment #3893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@lvyanquan @leonardBang PTAL. |
...java/org/apache/flink/cdc/connectors/mysql/source/parser/CustomAlterTableParserListener.java
Show resolved
Hide resolved
flink-cdc-common/src/main/java/org/apache/flink/cdc/common/event/AlterTableCommentEvent.java
Show resolved
Hide resolved
|
@yuxiqian Can you help review? |
|
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 60 days if no further activity occurs. |
|
Hi @ChaomingZhangCN, I apologize for not reviewing your changes in time during the past period due to other commitments. I believe this modification is reasonable. You can rebase with master (there may be conflicts), and I will review it in the coming days. |
No problem at all, thank you for the update! I appreciate your trust in the changes. I'll rebase with master and address any conflicts. Looking forward to your feedback in the coming days. |
e405d13 to
9b92048
Compare
https://issues.apache.org/jira/browse/FLINK-37203