[FLINK-37676][cdc-common] Add caching mechanism to Selectors for improved performance #3994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I think a JMH test for this will be better. |
joyCurry30
force-pushed
the
FLINK-37676
branch
2 times, most recently
from
3965e1b to
fe20665
Compare
yuxiqian
reviewed
May 8, 2025
flink-cdc-common/src/main/java/org/apache/flink/cdc/common/schema/Selectors.java
Show resolved
Hide resolved
yuxiqian
reviewed
May 8, 2025
flink-cdc-common/src/main/java/org/apache/flink/cdc/common/schema/Selectors.java
Show resolved
Hide resolved
|
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 60 days if no further activity occurs. |
Member
|
Could @joyCurry30 please rebase this PR with latest |
joyCurry30
force-pushed
the
FLINK-37676
branch
from
e6e1fa7 to
da668db
Compare
Contributor
Author
|
@yuxiqian done. cc plz. |
yuxiqian
approved these changes
Jan 4, 2026
Member
yuxiqian
left a comment
yuxiqian
left a comment
There was a problem hiding this comment.
Looks good, thank you for the nice work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to https://issues.apache.org/jira/browse/FLINK-37676
Adding a cache for better performance.