[FLINK-38806] Fix post-transform converters ineffective without projection or filter rules #4191
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes FLINK-38806.
A post-transform converter will not work if neither projection nor filter rule is defined, as such transform definitions are ignored in TransformTranslator.
Questionable code snippet:
// TransformTranslator.java for (TransformDef transform : transforms) { - if (transform.isValidProjection() || transform.isValidFilter()) { postTransformFunctionBuilder.addTransform( transform.getSourceTable(), transform.getProjection(), transform.getFilter(), transform.getPrimaryKeys(), transform.getPartitionKeys(), transform.getTableOptions(), transform.getPostTransformConverter(), supportedMetadataColumns); } }