Skip to content

Conversation

@yuxiqian
Copy link
Member

This closes FLINK-38806.

A post-transform converter will not work if neither projection nor filter rule is defined, as such transform definitions are ignored in TransformTranslator.

transform:
  - source-table: foo.bar
    converter-after-transform: SOFT_DELETE

Questionable code snippet:

// TransformTranslator.java

 for (TransformDef transform : transforms) {
-    if (transform.isValidProjection() || transform.isValidFilter()) {
         postTransformFunctionBuilder.addTransform(
                 transform.getSourceTable(),
                 transform.getProjection(),
                 transform.getFilter(),
                 transform.getPrimaryKeys(),
                 transform.getPartitionKeys(),
                 transform.getTableOptions(),
                 transform.getPostTransformConverter(),
                 supportedMetadataColumns);
     }
 }

Copy link
Contributor

@lvyanquan lvyanquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lvyanquan lvyanquan merged commit f520424 into apache:master Dec 16, 2025
59 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants