[test] Improve pipeline connector test coverage i.e. doris/postgres/fluss #4266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardBang
force-pushed
the
improve_doris_test_coverage
branch
from
82c7202 to
f2d280a
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds unit tests to increase connector utility coverage across multiple pipeline connectors, focusing on schema/type conversion helpers and field extraction logic.
Changes:
- Add
StarRocksUtilsTestto cover StarRocks table/type conversion and field getter behavior. - Add
PostgresTypeUtilsTestandPostgresSchemaUtilsTestto cover type handling and TableId conversion helpers. - Add
FlussConversionsTestto cover CDC-to-Fluss schema/table conversion and schema comparison behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-starrocks/src/test/java/org/apache/flink/cdc/connectors/starrocks/sink/StarRocksUtilsTest.java | New unit tests for StarRocks conversion utilities and RecordData field getters. |
| flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-postgres/src/test/java/org/apache/flink/cdc/connectors/postgres/utils/PostgresTypeUtilsTest.java | New unit tests for Postgres type conversion mode handlers (decimal/binary/temporal/etc.). |
| flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-postgres/src/test/java/org/apache/flink/cdc/connectors/postgres/utils/PostgresSchemaUtilsTest.java | New unit tests for quoting and CDC↔Debezium TableId conversions. |
| flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-fluss/src/test/java/org/apache/flink/cdc/connectors/fluss/utils/FlussConversionsTest.java | New unit tests for Fluss schema/table conversion and column comparison logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...gres/src/test/java/org/apache/flink/cdc/connectors/postgres/utils/PostgresTypeUtilsTest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[test] Improve pipeline connector test coverage i.e. doris/postgres/fluss connector