Skip to content

[FLINK-34901][connectors/jdbc]Update clause must EXCLUDED unique index. #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[FLINK-34901][connectors/jdbc]Update clause must EXCLUDED unique index. #108

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a8dbf1
[FLINK-34901][connectors/jdbc] Improve the performance of the update …
Mar 21, 2024
8be4bd4
[FLINK-34901][connectors/jdbc]update clause must EXCLUDED unique index.
Mrart May 23, 2024
0d51d73
Merge branch 'apache:main' into main
Mrart May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .../main/java/org/apache/flink/connector/jdbc/dialect/AbstractPostgresCompatibleDialect.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,14 @@ public String getLimitClause(long limit) {
@Override
public Optional<String> getUpsertStatement(
String tableName, String[] fieldNames, String[] uniqueKeyFields) {
Set<String> uniqueKeyFieldsSet = Arrays.stream(uniqueKeyFields).collect(Collectors.toSet());
String uniqueColumns =
Arrays.stream(uniqueKeyFields)
uniqueKeyFieldsSet.stream()
.map(this::quoteIdentifier)
.collect(Collectors.joining(", "));
String updateClause =
Arrays.stream(fieldNames)
.filter(f -> !uniqueKeyFieldsSet.contains(f))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious is this a bug or performance improvement?

Also cc @RocMarshal , would you mind reviewing this PR as well (as you are the active contributor of jdbc connector)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to add a test to check it if it's a bug.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mrart for the contribution & @1996fanrui for the ping.

It's better to add a test to check it if it's a bug.

+1.

.map(f -> quoteIdentifier(f) + "=EXCLUDED." + quoteIdentifier(f))
.collect(Collectors.joining(", "));
return Optional.of(
Expand Down