[FLINK-35870] Change DEFAULT_KAFKA_TRANSACTION_TIMEOUT in KafkaSinkBuilder #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) |
davidradl
reviewed
May 19, 2025
| @@ -61,7 +61,7 @@ | |||
| public class KafkaSinkBuilder<IN> { | |||
|
|
|||
| private static final Logger LOG = LoggerFactory.getLogger(KafkaSinkBuilder.class); | |||
| private static final Duration DEFAULT_KAFKA_TRANSACTION_TIMEOUT = Duration.ofHours(1); | |||
| private static final Duration DEFAULT_KAFKA_TRANSACTION_TIMEOUT = Duration.ofMinutes(15); | |||
There was a problem hiding this comment.
It seems a reasonable change, but I am concerned about changing the default of an option. The cautious approach would be to introduce a new parameter with the new default, so the user can choose when to move to the new default and there are no unexpected changes in behaviour for minor upgrades.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change
DEFAULT_KAFKA_TRANSACTION_TIMEOUTinKafkaSinkBuilderclass.The default value is 15 minutes, as shown in the official Kakfa documentation.
So I changed it from 1 hour to 15 minutes and added the test.
