Skip to content

Conversation

@gaborgsomogyi
Copy link
Contributor

This PR updates the Flink version to 2.2.0.

No mentionable change needed on the connector side.

@boring-cyborg
Copy link

boring-cyborg bot commented Dec 8, 2025

Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)

@gaborgsomogyi
Copy link
Contributor Author

cc @ferenc-csaky

@gaborgsomogyi gaborgsomogyi force-pushed the FLINK-38790 branch 8 times, most recently from 5a4ed73 to 9e3f014 Compare December 8, 2025 16:18
@gaborgsomogyi gaborgsomogyi force-pushed the FLINK-38790 branch 8 times, most recently from 8c6c0ee to 1fe56be Compare December 10, 2025 13:28
@gaborgsomogyi gaborgsomogyi force-pushed the FLINK-38790 branch 5 times, most recently from 30ccf4f to 14a3e6b Compare December 10, 2025 18:50
@gaborgsomogyi
Copy link
Contributor Author

Seem like one test hangs infinitely. If somebody has any idea why and how to solve then plz share

2025-12-10T19:41:02.7473262Z "main" #1 prio=5 os_prio=0 cpu=4081.65ms elapsed=2751.39s tid=0x00007fe15402a0e0 nid=0x48f3 waiting on condition  [0x00007fe159df9000]
2025-12-10T19:41:02.7473813Z    java.lang.Thread.State: WAITING (parking)
2025-12-10T19:41:02.7474384Z 	at jdk.internal.misc.Unsafe.park([email protected]/Native Method)
2025-12-10T19:41:02.7475137Z 	- parking to wait for  <0x0000000086400038> (a java.util.concurrent.CompletableFuture$Signaller)
2025-12-10T19:41:02.7475918Z 	at java.util.concurrent.locks.LockSupport.park([email protected]/LockSupport.java:211)
2025-12-10T19:41:02.7476762Z 	at java.util.concurrent.CompletableFuture$Signaller.block([email protected]/CompletableFuture.java:1864)
2025-12-10T19:41:02.7477642Z 	at java.util.concurrent.ForkJoinPool.unmanagedBlock([email protected]/ForkJoinPool.java:3465)
2025-12-10T19:41:02.7478529Z 	at java.util.concurrent.ForkJoinPool.managedBlock([email protected]/ForkJoinPool.java:3436)
2025-12-10T19:41:02.7479592Z 	at java.util.concurrent.CompletableFuture.waitingGet([email protected]/CompletableFuture.java:1898)
2025-12-10T19:41:02.7480465Z 	at java.util.concurrent.CompletableFuture.get([email protected]/CompletableFuture.java:2072)
2025-12-10T19:41:02.7481451Z 	at org.apache.flink.streaming.api.environment.StreamExecutionEnvironment.execute(StreamExecutionEnvironment.java:1878)
2025-12-10T19:41:02.7482585Z 	at org.apache.flink.streaming.api.environment.StreamExecutionEnvironment.execute(StreamExecutionEnvironment.java:1846)
2025-12-10T19:41:02.7483846Z 	at org.apache.flink.streaming.util.TestStreamEnvironment.execute(TestStreamEnvironment.java:238)
2025-12-10T19:41:02.7484859Z 	at org.apache.flink.streaming.api.environment.StreamExecutionEnvironment.execute(StreamExecutionEnvironment.java:1824)
2025-12-10T19:41:02.7485908Z 	at org.apache.flink.connector.kafka.sink.KafkaSinkITCase.testRecoveryWithAssertion(KafkaSinkITCase.java:656)
2025-12-10T19:41:02.7486991Z 	at org.apache.flink.connector.kafka.sink.KafkaSinkITCase.testRecoveryWithExactlyOnceGuarantee(KafkaSinkITCase.java:285)

@gaborgsomogyi gaborgsomogyi force-pushed the FLINK-38790 branch 3 times, most recently from c2e939f to 23e4432 Compare December 10, 2025 22:08
@gaborgsomogyi gaborgsomogyi force-pushed the FLINK-38790 branch 13 times, most recently from 61d5694 to 44d992f Compare December 11, 2025 12:40
@gaborgsomogyi gaborgsomogyi marked this pull request as draft December 11, 2025 12:40
@gaborgsomogyi gaborgsomogyi force-pushed the FLINK-38790 branch 9 times, most recently from f210a73 to 4dd96fe Compare December 11, 2025 14:27
@gaborgsomogyi
Copy link
Contributor Author

KafkaSinkITCase.testRecoveryWithExactlyOnceGuarantee(TransactionNamingStrategy.POOLING, false) waits infinitely for god knows why.

@@ -32,6 +32,9 @@ jobs:
flink_branches: &flink_branches_matrix [{
flink: 2.2-SNAPSHOT,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should change this to 2.3-SNAPSHOT

</executions>
</plugin>

<!-- Temporarily run only KafkaSinkITCase for faster feedback on hanging test issue -->
Copy link

@davidradl davidradl Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a Jira / PR link we can add here?

Are these unit test changes required for 2.2, if not a separate PR would seem more appropriate.

It would be good to describe the motivation for these other changes test changes and the change to thread safeness in the Jira text

strategy:
matrix:
flink: &flink_versions [ 2.0.1, 2.1.1 ]
flink: &flink_versions [ 2.2.0 ]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am curious why we did not add 2.2 to the existing list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants