[FLINK-25538] Migrate tests from JUnit 4 to JUnit 5 #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nnotations with global SPI registration
…ds following JUnit 5 best practices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates tests from JUnit 4 to JUnit 5 [FLINK-25538]. Split into 3 commits for easier review:
Commits
1. Migrate tests from JUnit 4 to JUnit 5
Main migration JUnit 4 -> JUnit 5. Compiles and tests pass.
2. Replace
@ExtendWith(TestLoggerExtension)with global SPI registrationUses SPI registration instead of
@ExtendWithon every class (feedback from #106)3. Remove optional public modifiers following JUnit 5 best practices
JUnit 5 doesn't require test classes/methods to be
public. Removed these modifiers from migrated files to match modern conventions (also what Sonar/other linters recommend). Files not migrated in this PR still keep theirpublicmodifiers.