[hotfix] Fix kafka connection flakiness in tests #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Efrat19
force-pushed
the
tests-flakeyness-fix
branch
from
64a6e42 to
6eb973a
Compare
CI pipelines are failing lately with kafka connection errors Possibly due to the test suite not waiting for the kafka brokers to be up This fix will wait with timeout until kafka container is ready or fail earlier
Efrat19
force-pushed
the
tests-flakeyness-fix
branch
from
6eb973a to
6dd4acf
Compare
Efrat19
changed the title
Savonitar
reviewed
Feb 3, 2026
| "PLAINTEXT:PLAINTEXT,BROKER:PLAINTEXT,CONTROLLER:PLAINTEXT") | ||
| .withEnv("KAFKA_INTER_BROKER_LISTENER_NAME", "BROKER"); | ||
| .withEnv("KAFKA_INTER_BROKER_LISTENER_NAME", "BROKER") | ||
| .waitingFor(Wait.forSuccessfulCommand(CONTAINER_STARTUP_CHECK).withStartupTimeout(CONTAINER_STARTUP_TIMEOUT)); |
Contributor
There was a problem hiding this comment.
Doesn't ConfluentKafkaContainer already have and use a wait strategy inside?
it has a wait strategy
in org.testcontainers.kafka.ConfluentKafkaContainer#ConfluentKafkaContainer(org.testcontainers.utility.DockerImageName)
this.waitingFor(KafkaHelper.WAIT_STRATEGY);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI pipelines are failing lately with kafka connection errors Possibly due to the test suite not waiting for the kafka brokers to be up This fix will wait with timeout until kafka container is ready or fail earlier
Example: https://github.com/apache/flink-connector-kafka/actions/runs/21477736651/job/62177678922?pr=217