[FLINK-39072] Handle InvalidPidMappingException as known failure in KafkaCommitter #225
+29
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…afkaCommitter When a Kafka transaction's producer ID mapping expires on the broker, commitTransaction() throws InvalidPidMappingException. Previously this fell through to the generic Exception handler, calling signalFailedWithUnknownReason which triggers a failover. On recovery the same expired transaction is replayed, causing an infinite restart loop. Catch InvalidPidMappingException explicitly and call signalFailedWithKnownReason so the framework's configured strategy can handle it (e.g., skip the unrecoverable transaction).
|
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) |
nateab
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Kafka transaction's producer ID mapping expires on the broker, commitTransaction() throws InvalidPidMappingException. Previously this fell through to the generic Exception handler, calling signalFailedWithUnknownReason which triggers a failover. On recovery the same expired transaction is replayed, causing an infinite restart loop.
Catch InvalidPidMappingException explicitly and call signalFailedWithKnownReason so the framework's configured strategy can handle it (e.g., skip the unrecoverable transaction).