Update to Flink 1.20 and Pulsar 3.0.2 with callbacks #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnBattista
force-pushed
the
attn/5_0/flink-1_20-pulsar-3_0_2
branch
from
2f7f17a to
e0de967
Compare
Fix issue with the SourceUserCallback not being called as expected
|
Looks like this repository is abandoned. |
ferenc-csaky
changed the title
ferenc-csaky
changed the title
|
Mostly superseded by #111. The callback logic is a net new feature here, and fails in some tests. I would handle that on its own scope anyways, so if there is still intent to add that feature I'd recommend updating this PR or open a new one after the mentioned PR is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows us to use flink 1.20 and pulsar 3.0.2 while including the custom callback code.