Skip to content

Conversation

@kornys
Copy link
Contributor

@kornys kornys commented Aug 11, 2025

What is the purpose of the change

  • Trivial code clean -> remove redundant implementation of Namespaces, since parent class already implements that interface.

Brief change log

(for example:)

  • Code clean remove redundant implementation of Namespaced interface

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changes to the CustomResourceDescriptors: (no)
  • Core observer or reconciler logic that is regularly executed: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

Copy link
Contributor

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kornys
Copy link
Contributor Author

kornys commented Aug 11, 2025

closing code is cherry-picked into #1011

@kornys kornys closed this Aug 11, 2025
@kornys kornys deleted the clean-redundant-implementation branch August 11, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants