Skip to content

Fix redundant implementation of interfaces and clean deprecated fabric8 methods #1011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 12, 2025
Merged

Fix redundant implementation of interfaces and clean deprecated fabric8 methods #1011

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eb1780b
Remove redundant implementation of Namespaced
kornys Aug 11, 2025
c5e1b01
Fix usage of deprectaed method createOrUpdate from fabric8
kornys Aug 11, 2025
db70725
Add .vscode into .gitignore
kornys Aug 11, 2025
0e686e2
Address comments
kornys Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,6 @@ buildNumber.properties
*.DS_Store

.kube

# VSCode settings
.vscode/
6 changes: 5 additions & 1 deletion examples/kubernetes-client-examples/src/main/java/org/apache/flink/examples/Basic.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,11 @@ public static void main(String[] args) {
.build());

try (KubernetesClient kubernetesClient = new KubernetesClientBuilder().build()) {
kubernetesClient.resource(flinkDeployment).createOrReplace();
if (kubernetesClient.resource(flinkDeployment).get() == null) {
kubernetesClient.resource(flinkDeployment).create();
} else {
kubernetesClient.resource(flinkDeployment).update();
}
}
}
}
4 changes: 1 addition & 3 deletions ...-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/FlinkDeployment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@

import com.fasterxml.jackson.annotation.JsonInclude;
import com.fasterxml.jackson.databind.annotation.JsonDeserialize;
import io.fabric8.kubernetes.api.model.Namespaced;
import io.fabric8.kubernetes.model.annotation.Group;
import io.fabric8.kubernetes.model.annotation.ShortNames;
import io.fabric8.kubernetes.model.annotation.Version;
Expand All @@ -37,8 +36,7 @@
@Version(CrdConstants.API_VERSION)
@ShortNames({"flinkdep"})
public class FlinkDeployment
extends AbstractFlinkResource<FlinkDeploymentSpec, FlinkDeploymentStatus>
implements Namespaced {
extends AbstractFlinkResource<FlinkDeploymentSpec, FlinkDeploymentStatus> {

@VisibleForTesting
@Override
Expand Down
4 changes: 1 addition & 3 deletions ...-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/FlinkSessionJob.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@

import com.fasterxml.jackson.annotation.JsonInclude;
import com.fasterxml.jackson.databind.annotation.JsonDeserialize;
import io.fabric8.kubernetes.api.model.Namespaced;
import io.fabric8.kubernetes.model.annotation.Group;
import io.fabric8.kubernetes.model.annotation.ShortNames;
import io.fabric8.kubernetes.model.annotation.Version;
Expand All @@ -36,8 +35,7 @@
@Version(CrdConstants.API_VERSION)
@ShortNames({"sessionjob"})
public class FlinkSessionJob
extends AbstractFlinkResource<FlinkSessionJobSpec, FlinkSessionJobStatus>
implements Namespaced {
extends AbstractFlinkResource<FlinkSessionJobSpec, FlinkSessionJobStatus> {

@Override
protected FlinkSessionJobStatus initStatus() {
Expand Down