Skip to content

Conversation

@csviri
Copy link
Contributor

@csviri csviri commented Aug 15, 2025

What is the purpose of the change

This change introduces config field for FlinkDeployment and FlinkSessionJob as an alternative to flinkConfiguration. While flinkConfiguration accepts string key-value pairs, the new field accepts arbitrary yaml input, as defined in flink configuration documentation.

While this change allows adding values to both flinkConfiguration and config, if there is a value with same key the one from config will take precedence. However, it is the users resposibility to make sure that there are no overlapping keys, thus keys with deprecated names and with actual key names, in that case behavior is not deterministic.

TODO: Flip

Brief change log

  • adds config to CRD
  • backfills flinkConfiguration from config

Verifying this change

TODO describe tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changes to the CustomResourceDescriptors: yes
  • Core observer or reconciler logic that is regularly executed: yes

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? docs and JavaDocs (TODO)

@csviri csviri changed the title [FLINK-37406] Add support for structured YAML config in FlinkDeployment CRD [WIP][FLINK-37406] Add support for structured YAML config in FlinkDeployment CRD Aug 15, 2025
@csviri
Copy link
Contributor Author

csviri commented Aug 18, 2025

replaced by: #1013

@csviri csviri closed this Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant