[WIP][FLINK-37406] Add support for structured YAML config in FlinkDeployment CRD #1012
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This change introduces
config
field forFlinkDeployment
andFlinkSessionJob
as an alternative toflinkConfiguration
. WhileflinkConfiguration
accepts string key-value pairs, the new field accepts arbitrary yaml input, as defined in flink configuration documentation.While this change allows adding values to both
flinkConfiguration
andconfig
, if there is a value with same key the one fromconfig
will take precedence. However, it is the users resposibility to make sure that there are no overlapping keys, thus keys with deprecated names and with actual key names, in that case behavior is not deterministic.TODO: Flip
Brief change log
config
to CRDflinkConfiguration
fromconfig
Verifying this change
TODO describe tests
Does this pull request potentially affect one of the following parts:
CustomResourceDescriptors
: yesDocumentation