- 
                Notifications
    
You must be signed in to change notification settings  - Fork 496
 
[FLINK-38448] Rework doc build and doc deployment #1035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ync-deploy` action in `docs.yaml`
a532617    to
    4b7038f      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a minimal context on why this change is required and where the new action.yml is coming from?
| 
           Context added to the Jira ticket. And the action.yml comes from me and ChatGPT :)  | 
    
| 
           How about we simply copy the appropriate action from the burnett01/rsync-deployments codebase: https://github.com/Burnett01/rsync-deployments/tree/7.1.0 We could copy the logic as is, and add the MIT license in:   | 
    
          
 That action runs in a Docker img. So we need to copy over pretty much the whole codebase (action.yml, Dockerfile, entrypoint.sh). It has the benefit of a fixed rsync version, I'm 99% sure it won't matter at all. I'm okay to do that though, just let me know if that would be preferred.  | 
    
| 
           Or as an alternative we could copy   | 
    
| 
           I was just looking at the current code and comparing with the entry point.sh/action.yml. It already looks very very similar .  | 
    
fcb4d44    to
    8171f59      
    Compare
  
    8171f59    to
    d5bf4e6      
    Compare
  
    burnett01/rsync-deployments with a custom rsync-deploy action in docs.yaml
No description provided.