[FLINK-36425][refactor] Replace jobStatus.state string with Flink JobStatus enum #886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gaborgsomogyi
left a comment
gaborgsomogyi
left a comment
There was a problem hiding this comment.
The change looks trivial and good. What I can't justify is why RestApiMetricsCollectorTest failed. Is that flaky?
gaborgsomogyi
approved these changes
Oct 4, 2024
Contributor
Author
Yes that test is flaky and not related/dependent on these changes. |
mxm
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Use / enforce the Flink JobStatus enum directly in job status.state this how we already use it and it would simplify the code in a lot of places to avoid string juggling .
Verifying this change
Tests have been updated to use/expect the enum and e2es should further cover existing behaviour.
The change have been manually verified with multiple envs and Flink versions.
Does this pull request potentially affect one of the following parts:
CustomResourceDescriptors: yes